test(sdk): match ban info entry by exact URI#3956
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit d3e0d9f) |
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Test-only change that tightens a substring URI match to an exact equality check in a banlist test. Both agents agree there are no in-scope defects and the change aligns with how ban_info() stores URIs via addr.to_string().
No in-scope findings.
Note: GitHub does not allow the PR author account to approve its own PR, so this clean automated review is posted as a comment review.
|
Closing this as obsolete: the target branch moved on and the brittle ban-info URI lookup was resolved directly on #3951. This stacked PR now conflicts with the updated branch. |
1 participant
Fixes the Copilot review note on #3951 by matching the ban-info entry using the exact address URI instead of a substring search for the port.
Validation:
CARGO_INCREMENTAL=0 git commit ...pre-commit hook passedcargo fmt --all -- --checkand workspacecargo checkCARGO_INCREMENTAL=0 cargo test -p rs-dapi-client test_invariant_genuine_failure_still_bans_with_unchanged_ladder